[Asterisk-code-review] res rtp: Fix regression when IPv6 is not available. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Nov 30 05:13:06 CST 2016


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4487 )

Change subject: res_rtp: Fix regression when IPv6 is not available.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4487/5/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

Line 1527: 	prm.tp_type = PJSIP_TRANSPORT_UDP6;
You can't check for just UDP6 because you can also have TCP6 and TLS6.

As well this needs to be run in a PJSIP thread so you have to queue a synchronous task.


-- 
To view, visit https://gerrit.asterisk.org/4487
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627a4e91795e821111e1cda523f083a40d0e0c3e
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list