[Asterisk-code-review] tcptls: Use new certificate upon sip reload (asterisk[13])

[Michael Kuron]

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4448 )

Change subject: tcptls: Use new certificate upon sip reload
......................................................................


Patch Set 6:

if the ast_calloc fails, it returns NULL and I already treat that gracefully by checking for NULL every time I use old_tls_cfg. So if the allocation fails, I assume that the TLS parameters need reloading and retry the allocation the next time ast_tcptls_server_start is called (e.g. at the next sip reload).

The only coding guideline violation I found is regarding sizeof(struct ...), which I'll fix. Are there any others?

-- 
To view, visit https://gerrit.asterisk.org/4448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e86cefc6dcd627c915134015a6a1ab1aadbe6
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No