[Asterisk-code-review] tcptls: Use new certificate upon sip reload (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4448 )

Change subject: tcptls: Use new certificate upon sip reload
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

The newly added code should still comply to the coding guidelines as Corey mentioned, and there's a minor off nominal case.

https://gerrit.asterisk.org/#/c/4448/6/main/tcptls.c
File main/tcptls.c:

Line 1075: 			desc->old_tls_cfg = ast_calloc(1, sizeof(struct ast_tls_config));
This can fail and the code should gracefully handle it as best it can.


-- 
To view, visit https://gerrit.asterisk.org/4448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e86cefc6dcd627c915134015a6a1ab1aadbe6
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes