[Asterisk-code-review] ari/resource channels: Add 'formats' to channel create/orig... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: ari/resource_channels:  Add 'formats' to channel create/originate
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2917/1/include/asterisk/codec.h
File include/asterisk/codec.h:

Line 80: 	/*! \brief The format name for this codec */
> The problem is that it may not be cached or the default.  For the built-ins
Ah, so you expect that this could be set by outside codecs. That wasn't clear. It should be more descriptive then. "A format name for a default sane format using this codec".


https://gerrit.asterisk.org/#/c/2917/1/main/codec_builtin.c
File main/codec_builtin.c:

Line 777: 		codec.format_name = (codec).name; \
> What would the scenario be given that this is called very early in asterisk
Disregard since this is internal to the built-ins.


-- 
To view, visit https://gerrit.asterisk.org/2917
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b23ecd41c1b4128d85028209772ee139f604b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes