[Asterisk-code-review] ari/resource channels: Add 'formats' to channel create/orig... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: ari/resource_channels:  Add 'formats' to channel create/originate
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.asterisk.org/#/c/2917/1/CHANGES
File CHANGES:

Line 71:  
> Redness
Done


Line 79:  
> Ditto
Done


https://gerrit.asterisk.org/#/c/2917/1/include/asterisk/codec.h
File include/asterisk/codec.h:

Line 80: 	/*! \brief The format name for this codec */
> The default cached format name for this codec
The problem is that it may not be cached or the default.  For the built-ins it is but if someone registers a new codec, we don't force them to create a format and even if they create a new format, we don't force them to cache it.

I'm not sure why this is because it would be more efficient to create and cache the format at codec registration time rather than during call processing.


https://gerrit.asterisk.org/#/c/2917/1/main/codec_builtin.c
File main/codec_builtin.c:

Line 777: 		codec.format_name = (codec).name; \
> Should these override if something else has already cached a format for the
What would the scenario be given that this is called very early in asterisk_daemon?


https://gerrit.asterisk.org/#/c/2917/1/rest-api/api-docs/channels.json
File rest-api/api-docs/channels.json:

Line 132:             {
> Is the indentation right for these two?
Weird.  Need to check my JSON editor settings.


-- 
To view, visit https://gerrit.asterisk.org/2917
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091b23ecd41c1b4128d85028209772ee139f604b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes