[Asterisk-code-review] translate: Enables native Packet-Loss Concealment (PLC) for ... (asterisk[master])

[Jaco Kroon]

Jaco Kroon has posted comments on this change.

Change subject: translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.asterisk.org/#/c/1820/9/main/translate.c
File main/translate.c:

PS9, Line 617: 	do {
> ast_frame_free(.) does free even those new frames. Therefore, in case of co
Please take a look at revision 11 I submitted.  I think it addresses al the concerns from everybody, including every concern I had.

No, ast_free called by the caller won't free all the frames, simply put - it has the pointer to the frame(s) it passed you, not the pointer to the now head of the linked list.  The passed frames forms the tail of the linked list you created by pre-pending frames, so the original passed tail will get free'd, not the full list.

Yes, you need to free those frames, and ONLY those frames that you allocated.  The simplest way to achieve this is to never allocate them in the first place (as per r11).


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 11
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes