[Asterisk-code-review] translate: Enables native Packet-Loss Concealment (PLC) for ... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.asterisk.org/#/c/1820/9/main/translate.c
File main/translate.c:

PS9, Line 617: temp = ast_frdup(&missed); /* does not duplicate LIST_NEXT */
> consume says to "free" the passed in frames. So if consume is false we must
ast_frame_free(.) does free even those new frames. Therefore, in case of consume = false, the one calling ast_translate does free those frames. Therefore, I do not see your memory leak, yet.

The question was/is: Should I free those frames added in ast_translate in any case of the parameter consume, or should those new frames stay there, because they should have been there anyway. The question is not ‘what does consume mean here in ast_translate‘. Instead, my question is: What happens to frames for which consume was false.

Or asked differently: To avoid a side effect by ast_translate, should I free those ‘new’ frames in any case of the parameter consume?


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 9
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes