[Asterisk-code-review] Dial: Add function to append already-created channel. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Dial: Add function to append already-created channel.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2512/1/main/dial.c
File main/dial.c:

PS1, Line 289: 	if (!dial || !tech || !device)
             : 		return -1;
             : 
             : 	/* Allocate new memory for dialed channel structure */
             : 	if (!(channel = ast_calloc(1, sizeof(*channel))))
             : 		return -1;
> Should get some curlie fries
I was trying not to change any formatting of existing code in order to not confuse what had actually been changed.


Line 373: 		if (!(channel->owner = ast_request(channel->tech, cap_request, &assignedids, chan, numsubst, &channel->cause))) {
> This long line needs to be wrapped.  There are better line breaks this way:
Same here. This is not new code from me, so my attempt here was not to mess with stuff that was already in the file.


-- 
To view, visit https://gerrit.asterisk.org/2512
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8179f64f8f99132f80dead8d5db2030fd2c0509
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes