[Asterisk-code-review] Dial: Add function to append already-created channel. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Dial: Add function to append already-created channel.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/2512/1/main/dial.c
File main/dial.c:

PS1, Line 289: 	if (!dial || !tech || !device)
             : 		return -1;
             : 
             : 	/* Allocate new memory for dialed channel structure */
             : 	if (!(channel = ast_calloc(1, sizeof(*channel))))
             : 		return -1;
Should get some curlie fries


Line 322: 	device++;
Did you mean:
*device++ = '\0';


Line 373: 		if (!(channel->owner = ast_request(channel->tech, cap_request, &assignedids, chan, numsubst, &channel->cause))) {
This long line needs to be wrapped.  There are better line breaks this way:

channel->owner = ast_request(...
    ...);
if (!channel->owner) {}


Line 1141: 		ast_log(LOG_NOTICE, "Hanging up the outbound channel...\n");
Left over debuging message?  If not maybe should add the channel name to the message.


-- 
To view, visit https://gerrit.asterisk.org/2512
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8179f64f8f99132f80dead8d5db2030fd2c0509
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes