[Asterisk-code-review] Fix Failing atxfer fail blond test (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Fix Failing atxfer_fail_blond test
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2434/1/configs/bridge/ast3/extensions.conf
File configs/bridge/ast3/extensions.conf:

Line 10: same => n,Echo()
> Was this line originally a Wait?  Maybe using Playback of tt-monkeys or som
The line was originally Wait(10000), so it was intended to be a "wait forever" condition.

The reason for the Echo is that Alice is attempting to use BackgroundDetect() in order to determine if she can hear incoming audio from Bob. Bob needs to echo the audio Alice is sending back to her in order for audio to be detected. Otherwise, no audio would be detected and the TALK_DETECTED variable would be undefined.

BTW, the implication here is indeed that the bridge test case has never been properly detecting a two-way audio path. The tests have happened to pass because an undefined TALK_DETECTED variable goes to the "pass" case.


-- 
To view, visit https://gerrit.asterisk.org/2434
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4175c3abd1cc1d2e71f3a73c3a11ea17436452
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes