[Asterisk-code-review] Fix Failing atxfer fail blond test (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Fix Failing atxfer_fail_blond test
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2434/1/configs/bridge/ast2/extensions.conf
File configs/bridge/ast2/extensions.conf:

Line 12: same => n,NoOp(TALK_DETECTED is ${TALK_DETECTED})
If TALK_DETECTED is empty we probably want to actually fail the test and not skip it.  We shouldn't get a dialplan syntax error because of it being empty.


https://gerrit.asterisk.org/#/c/2434/1/configs/bridge/ast3/extensions.conf
File configs/bridge/ast3/extensions.conf:

Line 10: same => n,Echo()
Was this line originally a Wait?  Maybe using Playback of tt-monkeys or some other file around 10 seconds would be better.  You would still have a timeout when the playback finishes and RTP would get sent to the peer.


-- 
To view, visit https://gerrit.asterisk.org/2434
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4175c3abd1cc1d2e71f3a73c3a11ea17436452
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes