[Asterisk-code-review] Restrict CLI/AMI commands on shutdown. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Restrict CLI/AMI commands on shutdown.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

In asterisk.c, You need to add to the allowed on shutdown list:
core stop gracefully
core restart gracefully
core stop when convenient
core restart when convenient

Arguably, the "when convenient" versions are the nicest and can conceivably be excluded from the "allowed on shutdown" list since they can only start a shutdown and not promote to a less nicer method.  I'd still include them for completeness.

https://gerrit.asterisk.org/#/c/2372/4/main/cli.c
File main/cli.c:

Line 2748: 		ast_free(duplicate);
         : 		return 0;
Existing bug:

Change this to goto done so the inuse flag can be decremented.


-- 
To view, visit https://gerrit.asterisk.org/2372
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8887e215ac352fadf7f4c1e082da9089b1421990
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes