[Asterisk-code-review] res pjsip: improve realtime performance #2 (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Jun 20 16:30:38 CDT 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip: improve realtime performance #2
......................................................................


Patch Set 3:

(2 comments)

Ok, I followed this through and I *think* the multiple endpoint issue is moot.  I just needed anough time to walk through the scenario and do some experimentation.

Still some things to deal with though...

https://gerrit.asterisk.org/#/c/2906/3/contrib/ast-db-manage/config/versions/ef7efc2d3964_ps_contacts_add_endpoint_and_modify_.py
File contrib/ast-db-manage/config/versions/ef7efc2d3964_ps_contacts_add_endpoint_and_modify_.py:

Please make sure this works on postgres as well as mysql.  We just had to fix one of the earlier ones because it failed on postgres.


https://gerrit.asterisk.org/#/c/2906/3/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

PS3, Line 249: 	/*! The name of the endpoint this contact belongs to */
             : 	AST_STRING_FIELD_EXTENDED(endpoint_name);
has to be at the end of the structure.


-- 
To view, visit https://gerrit.asterisk.org/2906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id324c1776fa55d3741e0c5457ecac0304cb1a0df
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list