[Asterisk-code-review] res pjsip: improve realtime performance #2 (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Mon Jun 20 11:42:54 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: improve realtime performance #2
......................................................................


Patch Set 3:

> > > Better but the issue with multiple endpoints remains.
 > >
 > > Could you, please, explain "issue with multiple endpoints"?
 > 
 > There isn't a 1 to 1 relationship between contact and endpoint. 
 > Multiple endpoints can reference the same aor and therefore the
 > same contact can be related to multiple endpoints.  With only 1
 > endpoint_name on the contact structure, which endpoint is it?

The one who created this contact.
Please, look at function ast_sip_location_add_contact_nolock
	if (endpoint) {
		ast_string_field_set(contact, endpoint_name, ast_sorcery_object_get_id(endpoint));
	}

-- 
To view, visit https://gerrit.asterisk.org/2906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id324c1776fa55d3741e0c5457ecac0304cb1a0df
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list