[Asterisk-code-review] ARI: Ensure proper channel state on operations. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: ARI: Ensure proper channel state on operations.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2926/2/res/ari/resource_channels.c
File res/ari/resource_channels.c:

Line 294: 	if (channel_state_invalid(control, response)) {
> This particular check seems wrong for answer.  The lower level checks in st
AST_FLAG_OUTGOING gets set when the channel is dialed, but it is not set at the time of channel creation.


-- 
To view, visit https://gerrit.asterisk.org/2926
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes