[Asterisk-code-review] ARI: Ensure proper channel state on operations. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Ensure proper channel state on operations.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/2926/2/res/ari/resource_channels.c
File res/ari/resource_channels.c:

PS2, Line 168: 	snapshot = stasis_app_control_get_snapshot(control);
             : 	if (!snapshot) {
             : 		return;
             : 	}
Existing bug:  Need to set ast_ari_response_error() with 404 channel not found response.


Line 294: 	if (channel_state_invalid(control, response)) {
This particular check seems wrong for answer.  The lower level checks in stasis_app_control_answer() check if the channel has the outgoing flag set and do not answer if so.

Do the stasis dialed channels get AST_FLAG_OUTGOING set on the channel?


Line 348: void ast_ari_channels_mute(struct ast_variable *headers,
mute/unmute missing the channel state check that you added the 412 response allow check in the res_ari_channels.c generated file.


Line 386: void ast_ari_channels_unmute(struct ast_variable *headers,
mute/unmute channel state check missing


-- 
To view, visit https://gerrit.asterisk.org/2926
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes