[Asterisk-code-review] core: Not the configured but granted number of possible file... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: core: Not the configured but granted number of possible file descriptors.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2969/1/main/asterisk.c
File main/asterisk.c:

Line 600: 	getrlimit(RLIMIT_NOFILE, &limits);
> I'd say just set limits.rlim_cur to something obviously wrong if it fails, 
This should not be put before the switch (cmd) statement as it should only be done if you are executing the command and not initializing the CLI or doing tab completion.


-- 
To view, visit https://gerrit.asterisk.org/2969
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2df5c58863b5007b34b77adbe28b885dfcdf7e0b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes