[Asterisk-code-review] core: Not the configured but granted number of possible file... (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: core: Not the configured but granted number of possible file descriptors.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2969/1/main/asterisk.c
File main/asterisk.c:

Line 600: 	getrlimit(RLIMIT_NOFILE, &limits);
> I had that initially, but I found no error case for getrlimit which could a
I'd say just set limits.rlim_cur to something obviously wrong if it fails, like -1 so that it's pretty obvious the value is invalid.


-- 
To view, visit https://gerrit.asterisk.org/2969
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2df5c58863b5007b34b77adbe28b885dfcdf7e0b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes