[Asterisk-code-review] Automatic conversion of tests to use realtime. (testsuite[master])

Richard Mudgett asteriskteam at digium.com
Sat Jan 23 16:06:08 CST 2016


Richard Mudgett has posted comments on this change.

Change subject: Automatic conversion of tests to use realtime.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/#/c/1802/5//COMMIT_MSG
Commit Message:

Line 27: This commit has "RFC" applied to it because it is, in my opinion, not
       : optimally implemented. With this change, you would need to modify every
       : test's test-config.yaml to have database settings in it. In order to
       : have static and realtime versions of identical tests, you'd need to
       : duplicate every test, as well.
Looks like the commit message needs to be updated more than just removing "RFC" from the summary line.


-- 
To view, visit https://gerrit.asterisk.org/1802
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ceaae8b8f4160a6d23f2062ce75017351c1559e
Gerrit-PatchSet: 5
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list