[Asterisk-code-review] Automatic conversion of tests to use realtime. (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: Automatic conversion of tests to use realtime.
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1802/5/lib/python/asterisk/astconfigparser.py
File lib/python/asterisk/astconfigparser.py:

Line 1: import re
Does this need a preamble?


https://gerrit.asterisk.org/#/c/1802/5/lib/python/asterisk/realtime_converter.py
File lib/python/asterisk/realtime_converter.py:

Line 1: #!/usr/bin/env python
preamble as well?


Line 192:     Since this uses the pluggable module framework, it can be applied to
        :     individual tests if desired.
Add a note/warning that one should not have this module configured as a global or individual test module at the same time.


-- 
To view, visit https://gerrit.asterisk.org/1802
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ceaae8b8f4160a6d23f2062ce75017351c1559e
Gerrit-PatchSet: 5
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes