[Asterisk-code-review] res pjsip mwi: Turn some NOTICEs and WARNINGs into debugs (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Feb 25 16:56:50 CST 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip_mwi:  Turn some NOTICEs and WARNINGs into debugs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2315/1/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 713: 		ast_debug(3, "Unable to locate aor %s. MWI subscription failed.\n",
> I disagree with this change and the one on line 719. In my opinion, off-nom
Not me (or any other admin).  If someone isn't getting their MWI then they're going to call or open a ticket and I'm going to look at their config first.  I don't need logs filled up with messages specific to a single user.

These are no worse than auth failed and we don't send messages for that.


-- 
To view, visit https://gerrit.asterisk.org/2315
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05e38a7ff6c2f2521146f4be6a79731b9864e61f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list