[Asterisk-code-review] res pjsip mwi: Turn some NOTICEs and WARNINGs into debugs (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_pjsip_mwi:  Turn some NOTICEs and WARNINGs into debugs
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2315/1/res/res_pjsip_mwi.c
File res/res_pjsip_mwi.c:

Line 713: 		ast_debug(3, "Unable to locate aor %s. MWI subscription failed.\n",
I disagree with this change and the one on line 719. In my opinion, off-nominal paths should not emit debug messages, especially debug level 3. Someone who has misconfigured a device to subscribe to a non-existent AOR or misconfigured a device to subscribe to an AOR with no mailboxes is probably going to search their logs for warnings or errors that explain why a 404 got sent.


-- 
To view, visit https://gerrit.asterisk.org/2315
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05e38a7ff6c2f2521146f4be6a79731b9864e61f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes