[Asterisk-code-review] main/cli.c: Refactor function to print seconds formatted (asterisk[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Fri Feb 19 10:58:32 CST 2016


Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: main/cli.c: Refactor function to print seconds formatted
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/2272/3/res/res_config_pgsql.c
File res/res_config_pgsql.c:

Line 1579: 	char buf[376];
> Where does this number come from?
>From  length connection_buffer + credential + "Connected to  for " + 1

In another comment i said the  assignment  of buffer to print should be by other way, like ast_str other thing. It could be in other patch.


-- 
To view, visit https://gerrit.asterisk.org/2272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb8634102cd11d3f8623398b279cb731bcde36c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list