[Asterisk-code-review] main/cli.c: Refactor function to print seconds formatted (asterisk[master])

[Walter Doekes]

Walter Doekes has posted comments on this change.

Change subject: main/cli.c: Refactor function to print seconds formatted
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/2272/3/addons/cdr_mysql.c
File addons/cdr_mysql.c:

Line 123: 		char status2[100];
Removing `= ""` appears to be wrong.

If it's not filled below, we get uninitialized mem copied into buf.


https://gerrit.asterisk.org/#/c/2272/3/cdr/cdr_pgsql.c
File cdr/cdr_pgsql.c:

Line 143: 		char status2[100];
Same here.


https://gerrit.asterisk.org/#/c/2272/3/main/cli.c
File main/cli.c:

Line 883: 		print_uptimestr(a->fd, ast_tvsub(curtime, ast_lastreloadtime), "Last reload:", printsec);
If you edit lines in an if() without {} braces, please add them. See the coding guidelines.


https://gerrit.asterisk.org/#/c/2272/3/res/res_config_ldap.c
File res/res_config_ldap.c:

Line 1841: 	char credentials[100];
And another one.


https://gerrit.asterisk.org/#/c/2272/3/res/res_config_pgsql.c
File res/res_config_pgsql.c:

Line 1579: 	char buf[376];
Where does this number come from?


-- 
To view, visit https://gerrit.asterisk.org/2272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb8634102cd11d3f8623398b279cb731bcde36c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes