[Asterisk-code-review] rtp engine: Allow more than 32 dynamic payload types. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: rtp_engine: Allow more than 32 dynamic payload types.
......................................................................


Patch Set 1:

I cannot offer any real-world experience with this, but I feel cautious like Josh does with this change. I can see this potentially causing failures with certain SIP equipment/providers because they are not equipped to deal with dynamic payloads below 96. In fact, I do not know how Asterisk itself would respond to a dynamic payload number below 96. It may work fine, but I'm not certain.

Accepting this change is difficult. On the one hand, the RFC allows this (although it is a MAY), so maybe it's fine to include. On the other hand, this is highly unorthodox, and so it has the potential to cause failures. It's also unreasonable to expect anyone to be able to test this against *all* equipment and providers, so I don't know how to proceed.

The real problem here is Asterisk's insistence on trying to pre-assign dynamic payload numbers. Asterisk should be able to have 100 different dynamic payload types registered, and then assign a payload number on the fly when a call is made/received. But that's a lot more difficult to fix.

-- 
To view, visit https://gerrit.asterisk.org/3681
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No