[Asterisk-code-review] res pjsip: Default endpoints to the "offline" status. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Default endpoints to the "offline" status.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3674/1/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 1295: 		ast_endpoint_set_state(persistent->endpoint, AST_ENDPOINT_OFFLINE);
I don't think this is quite right. Given the following scenarios I'll give what I think the state should be initially:

1. An endpoint with no AORs: Offline
2. An endpoint with an AOR with no contacts: Offline
3. An endpoint with an AOR with contacts and qualify turned off: Unknown
4. An endpoint with an AOR with contacts and qualify turned on: Offline

In the third case you don't know with certainty that they are offline, and calling them is still possible. If it starts out as offline but eventually gets to unknown that's okay as well. As long as it ends up there.


-- 
To view, visit https://gerrit.asterisk.org/3674
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99b84169393983453076f5e9c0d35ff313a456a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes