[Asterisk-code-review] pbx.c: Crash in handle hint change due to uninitialized values (asterisk[11])
Kevin Harwell
asteriskteam at digium.com
Wed Aug 17 17:56:54 CDT 2016
Hello Richard Mudgett, Anonymous Coward #1000019,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/3601
to look at the new patch set (#2).
Change subject: pbx.c: Crash in handle_hint_change due to uninitialized values
......................................................................
pbx.c: Crash in handle_hint_change due to uninitialized values
handle_hint_change calls extension_presence_state_helper, which returns the
presence state subtype and message when a valid state is available. If the
state is invalid then those values are not filled. If they have not been
properly initialized to NULL then when ast_free is later called on them
Asterisk crashes.
This patch initializes the subtype and message to NULL.
ASTERISK-25706 #close
patches:
0008-handle_hint_change-initialize-presence_state.patch
submitted by Tzafrir Cohen (license 5035)
Change-Id: I2eb08c68951b327c42df0798de60484c3a225a50
---
M main/pbx.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/01/3601/2
--
To view, visit https://gerrit.asterisk.org/3601
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2eb08c68951b327c42df0798de60484c3a225a50
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
More information about the asterisk-code-review
mailing list