[Asterisk-code-review] pbx.c: Crash in handle hint change due to uninitialized values (asterisk[11])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: pbx.c: Crash in handle_hint_change due to uninitialized values
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/3601/1/main/pbx.c
File main/pbx.c:

Line 6146: 	struct presencechange presence_state = {};
I think you may want to change the format here to be more compatible with other compilers.  Struct initialization has been fairly touchy when you want it to be initialized to all zeros.

ps = {
  .state = 0,
};


-- 
To view, visit https://gerrit.asterisk.org/3601
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb08c68951b327c42df0798de60484c3a225a50
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes