[Asterisk-code-review] res srtp: Move SDP SRTP code from the core to res srtp. (asterisk[14])

Richard Mudgett asteriskteam at digium.com
Wed Aug 10 17:42:37 CDT 2016


Hello Anonymous Coward #1000019, Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/3441

to look at the new patch set (#2).

Change subject: res_srtp: Move SDP SRTP code from the core to res_srtp.
......................................................................

res_srtp: Move SDP SRTP code from the core to res_srtp.

A patch made to the master branch (Now the 14 branch) inadvertently made
libsrtp a required dependency in order to compile Asterisk.  Rather than
create dummy defines to substitute for the defines supplied by libsrtp
when libsrtp is not available, most of the code in sdp_srtp.c is moved
into res_srtp.c.  This gets more code out of Asterisk's core that isn't
used when SRTP is not available.  This also makes another inadvertent
required dependency on libsrtp by Asterisk's core unlikely.

ASTERISK-26253 #close
Reported by: Ben Merrills

Change-Id: I0a46cde81501c0405399c2588633ae32706d1ee7
---
M include/asterisk/sdp_srtp.h
M main/sdp_srtp.c
M res/res_srtp.c
3 files changed, 711 insertions(+), 577 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/41/3441/2
-- 
To view, visit https://gerrit.asterisk.org/3441
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a46cde81501c0405399c2588633ae32706d1ee7
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>



More information about the asterisk-code-review mailing list