[Asterisk-code-review] res srtp: Move SDP SRTP code from the core to res srtp. (asterisk[14])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: res_srtp: Move SDP SRTP code from the core to res_srtp.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/3441/1/main/sdp_srtp.c
File main/sdp_srtp.c:

Line 41: struct ast_sdp_crypto_api *sdp_crypto_api;
This should be static.


https://gerrit.asterisk.org/#/c/3441/1/res/res_srtp.c
File res/res_srtp.c:

Line 667: 			p->tag, 128 + ((taglen & 0x0300) >> 2), p->local_key64) ;
Nit: extra space before ';'


-- 
To view, visit https://gerrit.asterisk.org/3441
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a46cde81501c0405399c2588633ae32706d1ee7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes