[Asterisk-code-review] PJSIP respond to emtpy SIP INFO packets (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: PJSIP respond to emtpy SIP INFO packets
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2710/1/res/res_pjsip_dtmf_info.c
File res/res_pjsip_dtmf_info.c:

Line 101: 		/* Some SBCs use emtpy INFO as a KEEPALIVE */
This code will now always send a 200 OK if it's not dtmf or dtmf-relay. This means that any handler executed after this which may want to handle other INFO packets can't. That's bad.

What does the INFO packet in question look like? Is there a way to differentiate them?

If there is then that's great, the logic can be changed. If not then this probably needs to be a change elsewhere where if all implementations are invoked and none send a response then we send a 200 OK.


-- 
To view, visit https://gerrit.asterisk.org/2710
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib27e4f07151e5aef28fa587e4ead36c5b87c43e0
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: snuffy <snuffy22 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes