[Asterisk-code-review] translate: Fix transcoding while different in frame size. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: translate: Fix transcoding while different in frame size.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/1154/3/codecs/codec_gsm.c
File codecs/codec_gsm.c:

Line 165: 	if (samples) {
> because we are at optimising, please, consider http://stackoverflow.com/que
Ok.  You are correct the test for pvt->samples isn't necessary.


https://gerrit.asterisk.org/#/c/1154/3/codecs/codec_speex.c
File codecs/codec_speex.c:

Line 308: 		} else if (!tmp->silent_state) {
> Not sure, if I understand:
The problem is you have no current frame to append to the result frame list.  I suppose you will have to use continue if tmp->silent_state is set to bypass the appending current frame linked list.

if (is_speech)
else if (!tmp->silent_state)
else continue


-- 
To view, visit https://gerrit.asterisk.org/1154
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e229569d73191d66a4e43fef35432db24000212
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes