[Asterisk-code-review] translate: Fix transcoding while different in frame size. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Fix transcoding while different in frame size.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/1154/3/codecs/codec_gsm.c
File codecs/codec_gsm.c:

Line 165: 	if (samples) {
> This should be:
because we are at optimising, please, consider http://stackoverflow.com/questions/3751797 and tell me your final decision


https://gerrit.asterisk.org/#/c/1154/3/codecs/codec_speex.c
File codecs/codec_speex.c:

Line 308: 		} else if (!tmp->silent_state) {
> I don't think there should be an else-if test and just an else.
Not sure, if I understand:
"tmp->silent_state" returned NULL in the previous code and
that state does nothing in the current code, therefore
I went for a "else if" and swapped the condition.


-- 
To view, visit https://gerrit.asterisk.org/1154
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e229569d73191d66a4e43fef35432db24000212
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes