[Asterisk-code-review] runtests: Add the ability to run the test suite in a loop (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: runtests: Add the ability to run the test suite in a loop
......................................................................


Patch Set 3:

> > (1 comment)
 > >
 > > I have mixed feelings about reusing the '-n' option so quickly.
 > > For moving forward maybe it would be good to document that short
 > > options are subject to change, and automated scripts should
 > always
 > > use long options only?
 > 
 > I actually renamed '-n' to '-d' specifically for this option.
 > First, I couldn't think of a better short letter that wasn't
 > already taken by a more appropriate option; second, I thought the
 > '-n' for dry run didn't make a lot of sense, other than the 'run'
 > ends in 'n'.
 > 
 > I'm happy to just make this '--number' - or, if we go with just a
 > long form name, '--iterations'.

I would not think someone would have '-n' in an automated script.  If '-n' becomes an invalid option it should cause an error message and no tests to run.  If we make it so './runtests.py -n' loops infinitely, that is very different from don't run at all (what happened yesterday).  That is my only concern.  I do agree though if we use a short option for '--number' then '-n' makes the most sense.  Not really sure we need a short form for this though, it's not like '-t' that you could specify multiple times.

-- 
To view, visit https://gerrit.asterisk.org/1529
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c65250a45e48dc36b7c4657d4cfbe63efeb1a6d
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No