[Asterisk-code-review] runtests: Add the ability to run the test suite in a loop (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: runtests: Add the ability to run the test suite in a loop
......................................................................


Patch Set 3:

> Rather than "-n -1" for loop forever, I'd make it "-n" with no
 > option argument for loop forever or specify a number of iterations:
 > "-n 5".
 > 
 > Optparse is deprecated BTW.

Nuts. optparse doesn't support the 'optional argument':

"Typically, a given option either takes an argument or it doesn’t. Lots of people want an “optional option arguments” feature, meaning that some options will take an argument if they see it, and won’t if they don’t. This is somewhat controversial, because it makes parsing ambiguous: if -a takes an optional argument and -b is another option entirely, how do we interpret -ab? Because of this ambiguity, optparse does not support this feature."

Of course, it looks like argparse does, so that's awkward. I'm a little hesitant to toss Python 2.6 out with this patch however. Any strong feelings if I stick with the -1?

-- 
To view, visit https://gerrit.asterisk.org/1529
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c65250a45e48dc36b7c4657d4cfbe63efeb1a6d
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No