[Asterisk-code-review] test-config.yaml.sample: Add some whitespace for readability (testsuite[master])

Matt Jordan asteriskteam at digium.com
Sun Oct 25 07:51:19 CDT 2015


Matt Jordan has posted comments on this change.

Change subject: test-config.yaml.sample: Add some whitespace for readability
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/1520/1/sample-yaml/test-config.yaml.sample
File sample-yaml/test-config.yaml.sample:

Line 80:     # A sequence of tags that categorize the test into groups of similar functionality
> Can we get a linefeed here?
That actually shows up in this patch in the patch series:

https://gerrit.asterisk.org/#/c/1521/1/sample-yaml/test-config.yaml.sample

When I ran git add -p, it added that linefeed to that patch as opposed to this clean up one.


Line 100:         -   # Check for thread usage in Asterisk.  Any threads present in Asterisk after test
> It would be better if the '-' was on it's own line, probably don't need an 
Agreed; fixed


Line 156:     add-test-to-search-path: 'True'
> 99 instances of 'add-test-to-search-path' uses the string 'True', 72 use th
Fixed


-- 
To view, visit https://gerrit.asterisk.org/1520
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95af9e13272bdc28c170eb3eccb9238c4be6ae32
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list