[Asterisk-code-review] test-config.yaml.sample: Add some whitespace for readability (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: test-config.yaml.sample: Add some whitespace for readability
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/1520/1/sample-yaml/test-config.yaml.sample
File sample-yaml/test-config.yaml.sample:

Line 80:     # A sequence of tags that categorize the test into groups of similar functionality
Can we get a linefeed here?


Line 100:         -   # Check for thread usage in Asterisk.  Any threads present in Asterisk after test
It would be better if the '-' was on it's own line, probably don't need an empty line in that case.  Having the '-' on the same line as the comment causes it to be visually lost, harder to see that it's a new section within testconditions.  This is more important for the 2nd/3rd/etc testconditions.  The '#' on its own line indented as a direct child of testconditions used to provide this visual queue.


Line 156:     add-test-to-search-path: 'True'
99 instances of 'add-test-to-search-path' uses the string 'True', 72 use the boolean True.  Assuming the boolean actually works I think we should not encourage use of the string.


-- 
To view, visit https://gerrit.asterisk.org/1520
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95af9e13272bdc28c170eb3eccb9238c4be6ae32
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes