[Asterisk-code-review] runtests: Add an option (-k|--keep-core) to keep a core file (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: runtests: Add an option (-k|--keep-core) to keep a core file
......................................................................


Patch Set 3:

> Any particular reason you used "string_{0}".format()?  Personally I
 > prefer the C/printf style string formatter, especially since that's
 > already used for the rest of the code.
 > 
 > Will still +1 the change, but would rather see it updated to use
 > the printf style formatter.

WELL...

The format style is actually now preferred in Python land, mostly because the % style may eventually go away in Python 3.x. If twisted ever gets itself all the way updated for Python 3.x, that may eventually affect us.

See: https://docs.python.org/release/3.1.5/library/stdtypes.html#old-string-formatting-operations

-- 
To view, visit https://gerrit.asterisk.org/1373
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a468e98811b1ff814fdb64aa6808eba3c17460b
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No