[Asterisk-code-review] runtests: Add an option (-k|--keep-core) to keep a core file (testsuite[master])

Corey Farrell asteriskteam at digium.com
Sat Oct 24 11:18:45 CDT 2015


Corey Farrell has posted comments on this change.

Change subject: runtests: Add an option (-k|--keep-core) to keep a core file
......................................................................


Patch Set 3: Code-Review+1

Any particular reason you used "string_{0}".format()?  Personally I prefer the C/printf style string formatter, especially since that's already used for the rest of the code.

Will still +1 the change, but would rather see it updated to use the printf style formatter.

-- 
To view, visit https://gerrit.asterisk.org/1373
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a468e98811b1ff814fdb64aa6808eba3c17460b
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list