[Asterisk-code-review] Testsuite: batched rls subscription failure (testsuite[master])
Corey Farrell
asteriskteam at digium.com
Sat Oct 24 11:30:10 CDT 2015
Corey Farrell has posted comments on this change.
Change subject: Testsuite: batched rls subscription failure
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/#/c/1438/1/tests/channels/pjsip/subscriptions/rls/rls_test.py
File tests/channels/pjsip/subscriptions/rls/rls_test.py:
Line 23: class RLSTest(VOIPListener):
> :) I anticipated this kind of question. In my commit comment, I briefly tou
It might be easier/faster to get this change merged if the class rename is done in one commit, with everything else in a second commit on a series. Personally I don't know anything about RLS, but could easily approve the rename of a class. Then someone who knows about RLS can just review the important part.
--
To view, visit https://gerrit.asterisk.org/1438
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3af00440aa011786afd3241bae27d39c3518079
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list