[Asterisk-code-review] Testsuite: batched rls subscription failure (testsuite[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: Testsuite: batched rls subscription failure
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1438/1/tests/channels/pjsip/subscriptions/rls/rls_test.py
File tests/channels/pjsip/subscriptions/rls/rls_test.py:

Line 23: class RLSTest(VOIPListener):
> Why was this class renamed?
:) I anticipated this kind of question. In my commit comment, I briefly touched on my substantiation for this kind of change (because it is so sweeping and for something so minor, seems at first like it's not really necessary.) In the original version of the code, there were two modules, rls_test and rls_integrity. rls_test (this module), had a class -> IntegrityCheck, and rls_integrity had a class -> RLSValidator. It was getting to be a hassle trying to keep up with which module contained which class and who was responsible for what, considering the names were similar to what the other module was actually doing. With so many moving pieces, I decided (after some discussion w/ Mark M.), to refactor this class's name to help simplify the debugging.


-- 
To view, visit https://gerrit.asterisk.org/1438
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3af00440aa011786afd3241bae27d39c3518079
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes