[Asterisk-code-review] StatsD: Write Testsuite tests (testsuite[master])

[Tyler Cambron]

Tyler Cambron has posted comments on this change.

Change subject: StatsD: Write Testsuite tests
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/mockd.py
File tests/apps/statsd/mockd.py:

Line 95:         if not is_correct:
       :             LOGGER.debug('Packet not specified in configuration')
> If the incoming packet doesn't match any expected values shouldn't this err
If it reaches this debug message, then is_correct is False. This will return false to whichever handler called check_message(). If this comes back as False, then message_received will kill the test and the test will fail by default. Does this sound correct? I think this is how it works. I do realize that I forgot logic to stop the test in _user_event_handler(), so I will add that.


-- 
To view, visit https://gerrit.asterisk.org/1392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93dbeea53cf978461151e9002af2afe1029ce8b
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Tyler Cambron <tcambron at digium.com>
Gerrit-HasComments: Yes