[Asterisk-code-review] StatsD: Write Testsuite tests (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: StatsD: Write Testsuite tests
......................................................................


Patch Set 2: Code-Review-1

(20 comments)

https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/mockd.py
File tests/apps/statsd/mockd.py:

Line 88:             print message
       :             print section
       :             print section[message_type]
Remove these print messages or if they are meant to be used for debugging then log them as such instead.


Line 95:         if not is_correct:
       :             LOGGER.debug('Packet not specified in configuration')
If the incoming packet doesn't match any expected values shouldn't this error out and fail the test? Thoughts?


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/nominal/configs/ast1/statsd.conf
File tests/apps/statsd/nominal/configs/ast1/statsd.conf:

Line 5: ;prefix =				; Prefix to prepend to all metrics
      : ;add_newline = no		; Append a newline to every event. This is
      : 						; useful if you want to run a fake statsd
      : 						; server using netcat (nc -lu 8125)
For each of the statsd.conf files remove the extraneous unused parameters.


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/nominal/test-config.yaml
File tests/apps/statsd/nominal/test-config.yaml:

Line 48:     minversion: '13.5.0'
This should be 13.6.0 - This will probably need to be done for all tests.


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
File tests/apps/statsd/off-nominal/empty_params/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
s/sending/sending empty/


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
File tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better reflect that this is testing an invalid case.


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
File tests/apps/statsd/off-nominal/invalid_value/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better reflect the test condition.


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
File tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better describe this test condition.


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
File tests/apps/statsd/off-nominal/no_metric/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better describe this test condition.


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/no_value/test-config.yaml
File tests/apps/statsd/off-nominal/no_value/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better describe this test condition.


Line 43:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/no_variable/test-config.yaml
File tests/apps/statsd/off-nominal/no_variable/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better describe this test condition.


Line 42:     minversion: '13.5.0'
13.6.0


https://gerrit.asterisk.org/#/c/1392/2/tests/apps/statsd/off-nominal/server_unavail/test-config.yaml
File tests/apps/statsd/off-nominal/server_unavail/test-config.yaml:

Line 3:         Test sending statistics to a StatsD server for the StatsD Dialplan
      :         Application
Change the summary to better describe this test condition.


Line 42:     minversion: '13.5.0'
13.6.0


-- 
To view, visit https://gerrit.asterisk.org/1392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id93dbeea53cf978461151e9002af2afe1029ce8b
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Tyler Cambron <tcambron at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes