[Asterisk-code-review] Build System: Support include-what-you-use. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Build System: Support include-what-you-use.
......................................................................


Patch Set 3: Code-Review-1

It appears you are correct, changes within AH_TOP / AH_BOTTOM do not actually cause any changes to configure.  Normally the user would get an error if configure is newer than makeopts.  Since configure timestamp change is not committed to git other users will not receive this error, so include/asterisk/autoconfig.h will never be regenerated.  For this reason I think we need to ensure the text of configure gets modified by this commit.

Maybe you can add a check to find the 'include-what-you-use' program and save the path to a make variable IWYU?  This way no further changes to configure will be needed before we can create a 'make check-iwyu' target.

-- 
To view, visit https://gerrit.asterisk.org/1717
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d3efa0826142ece9cbed2fd0d46f3b607fee6ae
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No