[Asterisk-code-review] Remote testsuite: make remote asterisk default ARI host (testsuite[master])

[Scott Griepentrog]

Scott Griepentrog has posted comments on this change.

Change subject: Remote testsuite: make remote asterisk default ARI host
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/1665/1/lib/python/asterisk/ari.py
File lib/python/asterisk/ari.py:

Line 65:             asterisks = self.global_config.config.get('asterisk-instances')
       :             if asterisks:
       :                 default_host = asterisks[0]['host']
> It's unfortunate that this doesn't actually support multiple Asterisk insta
Agreed.  Ideally, the concept of remote asterisk hosts would be used as a replacement for a local host.  That way if a test called for 3 asterisk instances, but I only configure one remote, the second two are constructed locally as before to test against the target.

For this to work, the asterisk instance index would need to be passed around to constructors, alongside the test_config.


-- 
To view, visit https://gerrit.asterisk.org/1665
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d784c100fb43bbd7f949d4fcd281853cc8593d
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes