[Asterisk-code-review] Remote testsuite: make remote asterisk default ARI host (testsuite[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: Remote testsuite: make remote asterisk default ARI host
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1665/1/lib/python/asterisk/ari.py
File lib/python/asterisk/ari.py:

Line 63:         default_host = '127.0.0.1'
Make this a global with DEFAULT_PORT:

DEFAULT_HOST = '127.0.0.1'

DEFAULT_PORT = 8088


Line 65:             asterisks = self.global_config.config.get('asterisk-instances')
       :             if asterisks:
       :                 default_host = asterisks[0]['host']
It's unfortunate that this doesn't actually support multiple Asterisk instances for ARI.

I don't think I'd change that now, it's just a bummer.


-- 
To view, visit https://gerrit.asterisk.org/1665
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0d784c100fb43bbd7f949d4fcd281853cc8593d
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes