[Asterisk-code-review] format cap: Don't append the 'none' format when appending all. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Nov 12 07:48:34 CST 2015


Hello Matt Jordan,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/1611

to look at the new patch set (#3).

Change subject: format_cap: Don't append the 'none' format when appending all.
......................................................................

format_cap: Don't append the 'none' format when appending all.

When appending all formats of a type all the codecs are iterated
and added. This operation was incorrectly adding the ast_format_none
format which is special in that it is supposed to be used when no
format is present. It shouldn't be appended.

ASTERISK-25535

Change-Id: I7b00f3bdf4a5f3022e483d6ece602b1e8b12827c
---
M main/format_cap.c
M tests/test_format_cap.c
2 files changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/1611/3
-- 
To view, visit https://gerrit.asterisk.org/1611
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b00f3bdf4a5f3022e483d6ece602b1e8b12827c
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list