[Asterisk-code-review] format cap: Don't append the 'none' format when appending all. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Thu Nov 12 07:32:42 CST 2015


Corey Farrell has posted comments on this change.

Change subject: format_cap: Don't append the 'none' format when appending all.
......................................................................


Patch Set 2:

What if all video codecs are requested and none are available?  Shouldn't this fall-back to appending ast_format_none?  I mean by returning '0' is this function obligated to return a non-empty format_cap?

-- 
To view, visit https://gerrit.asterisk.org/1611
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b00f3bdf4a5f3022e483d6ece602b1e8b12827c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list