[Asterisk-code-review] res pjsip: Deny requests when threadpool queue is backed up. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip: Deny requests when threadpool queue is backed up.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/1607/1//COMMIT_MSG
Commit Message:

Line 7: res_pjsip: Deny requests when threadpool queue is backed up.
This issue is likely to be seen by users so we may want to create an ASTERISK issue.


https://gerrit.asterisk.org/#/c/1607/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 249: #define SIP_MAX_QUEUE 500l
> The max queue size is technically an implementation detail of the threadpoo
Please use L and not lowercase.  It looked really odd in the review email.


Line 285: 	if (ast_sip_threadpool_queue_size() > SIP_MAX_QUEUE) {
Should have some hysteresis to the throttling.


Line 286: 		/* This may mean an allocation failure, but it's more likely that
        : 		 * conditions have become unfavorable, resulting in a full queue.
        : 		 * It's in our best interest to send back a 503 response and be
        : 		 * done with it.
Comment is no longer accurate.


-- 
To view, visit https://gerrit.asterisk.org/1607
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e736d48a2ba79fd1f8056c0dcd330e38e6a3816
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes