[Asterisk-code-review] res pjsip: Deny requests when threadpool queue is backed up. (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: res_pjsip: Deny requests when threadpool queue is backed up.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/1607/1/res/res_pjsip.c
File res/res_pjsip.c:

Line 3758: long ast_sip_threadpool_queue_size(void) {
Missing a newline here


https://gerrit.asterisk.org/#/c/1607/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

Line 249: #define SIP_MAX_QUEUE 500l
The max queue size is technically an implementation detail of the threadpool, which the SIP stack needs to be aware of.

I'd just expose the #define in threadpool.h - that way, it can be used by anyone who cares, and we won't get into a discontinuity between the SIP stack and the actual max queue size used by the threadpool.


-- 
To view, visit https://gerrit.asterisk.org/1607
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e736d48a2ba79fd1f8056c0dcd330e38e6a3816
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes